Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enforce order of dependency when building addons #17048

Closed
wants to merge 1 commit into from
Closed

build: enforce order of dependency when building addons #17048

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Fixes: #17043 (Hopefully)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 15, 2017
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11456/

@joyeecheung
Copy link
Member Author

cc @refack

@joyeecheung
Copy link
Member Author

..hmm...still reproduce on smartos: https://ci.nodejs.org/job/node-test-commit-smartos/13154/nodes=smartos16-64/console

@addaleax
Copy link
Member

Landed in c5b8e16

@addaleax addaleax closed this Nov 18, 2017
addaleax pushed a commit that referenced this pull request Nov 18, 2017
@joyeecheung @addaleax
build: enforce order of dependency when building addons
c5b8e16 
PR-URL: #17048
Fixes: #17043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@joyeecheung joyeecheung mentioned this pull request Nov 19, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@joyeecheung @MylesBorins
build: enforce order of dependency when building addons
035a24e 
PR-URL: #17048
Fixes: #17043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@joyeecheung @gibfahn
build: enforce order of dependency when building addons
f0fb1d4 
PR-URL: #17048
Fixes: #17043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins
Copy link
Contributor

This does not land cleanly on v6.x should it be backported?

@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@joyeecheung @gibfahn
build: enforce order of dependency when building addons
3036b36 
PR-URL: #17048
Fixes: #17043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build: Makefile dependency regression
6 participants
@joyeecheung @addaleax @MylesBorins @jasnell @gibfahn @nodejs-github-bot